Page MenuHomePhabricator

Remove redundant connect_nodes call in abc-parkedchain.py
ClosedPublic

Authored by jasonbcox on Dec 13 2018, 01:47.

Details

Summary

setup_network does this automatically, so this call is redundant.
Originally, I discovered this while looking for the root cause of this test's
flakiness.

Test Plan

for i in {1..150}; do ./test_runner.py abc-parkedchain; done
Test is still flaky, but passes 99%+ of the time with this change still.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2189
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4368
Build 6801: Bitcoin ABC Buildbot (legacy)
Build 6800: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 13 2018, 01:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2018, 01:47
Herald added a subscriber: schancel. · View Herald Transcript
Fabien requested changes to this revision.Dec 13 2018, 16:06
Fabien added inline comments.
test/functional/abc-parkedchain.py
129 ↗(On Diff #6335)

This should not be needed. I suppose that you want the ensure that node tip and parking_node tip is the same, which is tested below.
This has been discussed with @deadalnix in another diff, and using a dedicated wait_until function seems to be a better way to do this:

def wait_for_tip(node, tip):
    def check_tip():
        return node.getbestblockhash() == tip
    wait_until(check_tip)
        
wait_for_tip(parking_node, good_tip)
This revision now requires changes to proceed.Dec 13 2018, 16:06
jasonbcox updated this revision to Diff 6402.Dec 21 2018, 21:47

Use wait_until according to feedback

Fabien accepted this revision.Dec 22 2018, 08:50
This revision is now accepted and ready to land.Dec 22 2018, 08:50
This revision was automatically updated to reflect the committed changes.