Remove redundant connect_nodes call in abc-parkedchain.py
ClosedPublic
Actions

Authored by jasonbcox on Dec 13 2018, 01:47.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING570a09320a31: Remove redundant connect_nodes call in abc-parkedchain.py
rABC570a09320a31: Remove redundant connect_nodes call in abc-parkedchain.py

Summary

setup_network does this automatically, so this call is redundant.
Originally, I discovered this while looking for the root cause of this test's
flakiness.

Test Plan

for i in {1..150}; do ./test_runner.py abc-parkedchain; done
Test is still flaky, but passes 99%+ of the time with this change still.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

parkedfix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4307
Build 6679: Bitcoin ABC Buildbot (legacy)
Build 6678: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 13 2018, 01:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2018, 01:47

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4307: Diff 6335.Dec 13 2018, 01:58

Fabien requested changes to this revision.Dec 13 2018, 16:06

Fabien added inline comments.

test/functional/abc-parkedchain.py
129	This should not be needed. I suppose that you want the ensure that node tip and parking_node tip is the same, which is tested below. This has been discussed with @deadalnix in another diff, and using a dedicated wait_until function seems to be a better way to do this: def wait_for_tip(node, tip): def check_tip(): return node.getbestblockhash() == tip wait_until(check_tip) wait_for_tip(parking_node, good_tip)