Page MenuHomePhabricator
Differential D218

Format all unformated files in the wallet
ClosedPublic
Actions

Authored by deadalnix on Jun 16 2017, 22:26.

Details

Reviewers
freetrader
sickpig
awemany
kyuupichan
Group Reviewers
Restricted Project
Commits
rSTAGING7d2364217306: Format all unformated files in the wallet
rABC7d2364217306: Format all unformated files in the wallet
Summary

AS per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletfmt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 327
Build 327: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 16 2017, 22:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2017, 22:26
freetrader added inline comments.Jun 17 2017, 03:20
src/wallet/db.h
30

Interesting warning.

When I attempted to pass down a Config to initialize() in the main app, I got a hang on the splash screen.

Don't know enough about Qt - why would static initialized data disturb the app ?

freetrader accepted this revision.Jun 17 2017, 03:21
This revision is now accepted and ready to land.Jun 17 2017, 03:21
Closed by commit rABC7d2364217306: Format all unformated files in the wallet (authored by deadalnix, committed by deadalnix). · Explain WhyJun 17 2017, 20:58
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
43 lines
156 lines
276 lines
test/
304 lines
5 lines

Diff 536

View Options

src/wallet/coincontrol.h

Loading...
View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/test/crypto_tests.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.h

Loading...