Perform member initialization in initialization lists where possible
ClosedPublic
Actions

Authored by Fabien on Dec 17 2018, 16:09.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING588b824d0d54: Perform member initialization in initialization lists where possible
rABC588b824d0d54: Perform member initialization in initialization lists where possible

Summary

Backport of core PR10523

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10523

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4326
Build 6717: Bitcoin ABC Buildbot (legacy)
Build 6716: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 17 2018, 16:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2018, 16:09

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4326: Diff 6356.Dec 17 2018, 16:20

jasonbcox accepted this revision.Dec 18 2018, 00:07

This revision is now accepted and ready to land.Dec 18 2018, 00:08

Fabien added a child revision: D2207: Declare single-argument (non-converting) constructors "explicit".Dec 19 2018, 10:45

Closed by commit rABC588b824d0d54: Perform member initialization in initialization lists where possible (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyDec 19 2018, 11:01

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

primitives/

block.h

2 lines

rpc/

jsonrpcrequest.h

6 lines

wallet/

wallet.h

2 lines

Diff 6356

View Options

src/primitives/block.h

View Options

src/rpc/jsonrpcrequest.h

View Options

Perform member initialization in initialization lists where possibleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6356

src/primitives/block.h

src/rpc/jsonrpcrequest.h

src/wallet/wallet.h

Perform member initialization in initialization lists where possible
ClosedPublic
Actions

Revision Contents
Changeset List