Page MenuHomePhabricator

Merge #11638: [tests] Dead mininode code
ClosedPublic

Authored by jasonbcox on Dec 21 2018, 00:37.

Details

Summary

Backport of Core PR 11638
Completes T467

Note: Some changes in the original PR will appear to be missing or
different due to changes in 35638ea8b and ce143f3048.

Original PR description:

fb00c45c3 [tests] Explicitly disallow support for p2p versions below 60001 (John Newbery)
3858aabbd [tests] Remove support for p2p alert messages (John Newbery)
c0b127470 [tests] Remove support for bre-BIP31 ping messages (John Newbery)
2904e301c [tests] Remove dead code from mininode.py (John Newbery)

Pull request description:

  This is the first part of #11518. It removes a ~150 lines of unused code from the mininode module:

  - remove unused `deliver_sleep_time` and `EarlyDisconnectError` code
  - remove support for pre-BIP31 ping messages
  - remove support for alert message
  - explicitly don't support p2p versions lower than 60001

  Should be an easy ACK for reviewers. If all extended tests pass, then this code really was dead :)

Tree-SHA512: 508e612ceb0b094250d18e75522d51e6b14cd069443050ba4af34d6f890c58721cb5653e8bc000b60635b9474d035b0dcd9c509c0dcdb3a7501df17b787f83b0
Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Dec 21 2018, 00:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 00:37
Herald added a subscriber: schancel. · View Herald Transcript
Fabien added inline comments.Dec 21 2018, 08:00
test/functional/test_framework/mininode.py
1472 ↗(On Diff #6380)

Are ver_send and ver_recv still necessary ?

deadalnix accepted this revision.Dec 21 2018, 08:51
This revision is now accepted and ready to land.Dec 21 2018, 08:51
jasonbcox added inline comments.Dec 21 2018, 21:19
test/functional/test_framework/mininode.py
1472 ↗(On Diff #6380)

Possibly not. In the interest of bringing our backports up-to-date, I'm going to leave it for now.

This revision was automatically updated to reflect the committed changes.