Page MenuHomePhabricator
Differential D2210

Merge #11638: [tests] Dead mininode code
ClosedPublic
Actions

Authored by jasonbcox on Dec 21 2018, 00:37.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGb36d97b25971: Merge #11638: [tests] Dead mininode code
rABCb36d97b25971: Merge #11638: [tests] Dead mininode code
Summary

Backport of Core PR 11638
Completes T467

Note: Some changes in the original PR will appear to be missing or
different due to changes in 35638ea8b and ce143f3048.

Original PR description:

fb00c45c3 [tests] Explicitly disallow support for p2p versions below 60001 (John Newbery)
3858aabbd [tests] Remove support for p2p alert messages (John Newbery)
c0b127470 [tests] Remove support for bre-BIP31 ping messages (John Newbery)
2904e301c [tests] Remove dead code from mininode.py (John Newbery)

Pull request description:

  This is the first part of #11518. It removes a ~150 lines of unused code from the mininode module:

  - remove unused `deliver_sleep_time` and `EarlyDisconnectError` code
  - remove support for pre-BIP31 ping messages
  - remove support for alert message
  - explicitly don't support p2p versions lower than 60001

  Should be an easy ACK for reviewers. If all extended tests pass, then this code really was dead :)

Tree-SHA512: 508e612ceb0b094250d18e75522d51e6b14cd069443050ba4af34d6f890c58721cb5653e8bc000b60635b9474d035b0dcd9c509c0dcdb3a7501df17b787f83b0
Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11638
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4335
Build 6735: Bitcoin ABC Buildbot (legacy)
Build 6734: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 21 2018, 00:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 00:37
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 21 2018, 00:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4335: Diff 6380.Dec 21 2018, 00:48
teamcity added a comment.Dec 21 2018, 00:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added inline comments.Dec 21 2018, 08:00
test/functional/test_framework/mininode.py
1472

Are ver_send and ver_recv still necessary ?

deadalnix accepted this revision.Dec 21 2018, 08:51
This revision is now accepted and ready to land.Dec 21 2018, 08:51
jasonbcox added inline comments.Dec 21 2018, 21:19
test/functional/test_framework/mininode.py
1472

Possibly not. In the interest of bringing our backports up-to-date, I'm going to leave it for now.

Closed by commit rABCb36d97b25971: Merge #11638: [tests] Dead mininode code (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyDec 21 2018, 21:59
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D4010: Fix incorrectly backported return statements in mininode.py.Sep 5 2019, 21:34
jasonbcox mentioned this in rABC27ebde13667a: Fix incorrectly backported return statements in mininode.py.Sep 6 2019, 15:15
jasonbcox mentioned this in rSTAGING27ebde13667a: Fix incorrectly backported return statements in mininode.py.Sep 19 2019, 02:09

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
121 lines

Diff 6380

View Options

test/functional/test_framework/mininode.py

Loading...