Page MenuHomePhabricator
Differential D2251

Use information stored in TestNode to connect nodes via p2p and RPC
ClosedPublic
Actions

Authored by deadalnix on Jan 3 2019, 21:32.

Details

Reviewers
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING3db2f5fe86eb: Use information stored in TestNode to connect nodes via p2p and RPC
rABC3db2f5fe86eb: Use information stored in TestNode to connect nodes via p2p and RPC
Summary

As per title.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 3 2019, 21:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2019, 21:32
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 3 2019, 21:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4407: Diff 6496!Jan 3 2019, 21:40
teamcity added a comment.Jan 3 2019, 21:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix mentioned this in D2159: [Part 1 of 4] [qa] De-globalize port seeding.Jan 3 2019, 21:56
jasonbcox requested changes to this revision.Jan 3 2019, 22:56
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/rpcbind_test.py
57 ↗(On Diff #6496)

Looks like using the same variable name as a function is causing assignment issues based on the test failure.

This revision now requires changes to proceed.Jan 3 2019, 22:56
deadalnix updated this revision to Diff 6501.Jan 4 2019, 14:47

Fix rpcbind

teamcity added a comment.Jan 4 2019, 14:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4411: Diff 6501.Jan 4 2019, 14:57
teamcity added a comment.Jan 4 2019, 14:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien requested changes to this revision.Jan 4 2019, 17:56
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpcbind_test.py
33 ↗(On Diff #6501)

Use self.log.info("Set host to {}".format(str(connect_to)) instead

This revision now requires changes to proceed.Jan 4 2019, 17:56
deadalnix updated this revision to Diff 6509.Jan 4 2019, 19:51

Remove superfluous log

teamcity added a comment.Jan 4 2019, 19:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 4 2019, 19:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4414: Diff 6509.Jan 4 2019, 19:59
teamcity added a comment.Jan 5 2019, 06:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 5 2019, 06:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 5 2019, 06:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 5 2019, 06:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jan 5 2019, 06:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jan 5 2019, 06:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Fabien accepted this revision.Jan 5 2019, 12:14
jasonbcox accepted this revision.Jan 7 2019, 06:58
This revision is now accepted and ready to land.Jan 7 2019, 06:58
Closed by commit rABC3db2f5fe86eb: Use information stored in TestNode to connect nodes via p2p and RPC (authored by deadalnix). · Explain WhyJan 7 2019, 14:15
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
15 lines
test_framework/
2 lines
6 lines
17 lines

Diff 6539

View Options

test/functional/rpcbind_test.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...