Page MenuHomePhabricator

Use information stored in TestNode to connect nodes via p2p and RPC
ClosedPublic

Authored by deadalnix on Thu, Jan 3, 21:32.

Details

Summary

As per title.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Thu, Jan 3, 21:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 3, 21:32
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox requested changes to this revision.Thu, Jan 3, 22:56
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/rpcbind_test.py
57 ↗(On Diff #6496)

Looks like using the same variable name as a function is causing assignment issues based on the test failure.

This revision now requires changes to proceed.Thu, Jan 3, 22:56
deadalnix updated this revision to Diff 6501.Fri, Jan 4, 14:47

Fix rpcbind

Fabien requested changes to this revision.Fri, Jan 4, 17:56
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpcbind_test.py
33 ↗(On Diff #6501)

Use self.log.info("Set host to {}".format(str(connect_to)) instead

This revision now requires changes to proceed.Fri, Jan 4, 17:56
deadalnix updated this revision to Diff 6509.Fri, Jan 4, 19:51

Remove superfluous log

Fabien accepted this revision.Sat, Jan 5, 12:14
jasonbcox accepted this revision.Mon, Jan 7, 06:58
This revision is now accepted and ready to land.Mon, Jan 7, 06:58
This revision was automatically updated to reflect the committed changes.