Page MenuHomePhabricator

Use information stored in TestNode to connect nodes via p2p and RPC
ClosedPublic

Authored by deadalnix on Jan 3 2019, 21:32.

Details

Summary

As per title.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hostrpchost
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4407
Build 6879: Bitcoin ABC Buildbot (legacy)
Build 6878: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Jan 3 2019, 22:56
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/rpcbind_test.py
57

Looks like using the same variable name as a function is causing assignment issues based on the test failure.

This revision now requires changes to proceed.Jan 3 2019, 22:56
Fabien requested changes to this revision.Jan 4 2019, 17:56
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpcbind_test.py
33 ↗(On Diff #6501)

Use self.log.info("Set host to {}".format(str(connect_to)) instead

This revision now requires changes to proceed.Jan 4 2019, 17:56
This revision is now accepted and ready to land.Jan 7 2019, 06:58
This revision was automatically updated to reflect the committed changes.