Page MenuHomePhabricator

Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location
ClosedPublic

Authored by jasonbcox on Thu, Jan 10, 04:39.

Details

Summary

The manifest files have been left out of releases in the past. Until this is crystallized into our process via a script, adding this reminder will be helpful.

Test Plan

Copy the files as instructed while gitian building

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Thu, Jan 10, 04:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 10, 04:39
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Thu, Jan 10, 17:22
deadalnix added inline comments.
doc/gitian-building.md
111 ↗(On Diff #6582)

Just add the command required. Adding 2 move command is shorter than this whole paragraph and it is instruction i can follow instead of playing detective.

This revision now requires changes to proceed.Thu, Jan 10, 17:22
jasonbcox updated this revision to Diff 6590.Thu, Jan 10, 19:11

Updated according to feedback, including command from the old comment

deadalnix requested changes to this revision.Thu, Jan 10, 21:26
deadalnix added inline comments.
doc/gitian-building.md
112 ↗(On Diff #6590)

You add a cp after each build command, you get 3 lines and followable instructions. You donot, then you get a comment that is 5 lines long that that one has to decypher to figure out what to do. In what world is that better ?

This revision now requires changes to proceed.Thu, Jan 10, 21:26
jasonbcox retitled this revision from Add reminder to copy the manifest files as part of the gitian building process, as they're generated in a separate location to Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location.Fri, Jan 11, 18:53
jasonbcox updated this revision to Diff 6619.Fri, Jan 11, 18:58

Rebase + don't be dumb and actually give the commands to complete the task without having to think about it

deadalnix accepted this revision.Fri, Jan 11, 19:01
This revision is now accepted and ready to land.Fri, Jan 11, 19:01
This revision was automatically updated to reflect the committed changes.