Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location
ClosedPublic
Actions

Authored by jasonbcox on Jan 10 2019, 04:39.

Details

Reviewers

deadalnix
Fabien
Mengerian

Group Reviewers

Restricted Project

Commits

rSTAGING6b1219302b6f: Add commands to copy the manifest files as part of the gitian building process…
rABC6b1219302b6f: Add commands to copy the manifest files as part of the gitian building process…

Summary

The manifest files have been left out of releases in the past. Until this is crystallized into our process via a script, adding this reminder will be helpful.

Test Plan

Copy the files as instructed while gitian building

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jan 10 2019, 04:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2019, 04:39

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4464: Diff 6582.Jan 10 2019, 04:50

deadalnix requested changes to this revision.Jan 10 2019, 17:22

deadalnix added inline comments.

doc/gitian-building.md
111 ↗	(On Diff #6582)	Just add the command required. Adding 2 move command is shorter than this whole paragraph and it is instruction i can follow instead of playing detective.

This revision now requires changes to proceed.Jan 10 2019, 17:22

Updated according to feedback, including command from the old comment

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4472: Diff 6590.Jan 10 2019, 19:21

deadalnix requested changes to this revision.Jan 10 2019, 21:26

deadalnix added inline comments.

doc/gitian-building.md
112 ↗	(On Diff #6590)	You add a cp after each build command, you get 3 lines and followable instructions. You donot, then you get a comment that is 5 lines long that that one has to decypher to figure out what to do. In what world is that better ?

This revision now requires changes to proceed.Jan 10 2019, 21:26

jasonbcox retitled this revision from Add reminder to copy the manifest files as part of the gitian building process, as they're generated in a separate location to Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location.Jan 11 2019, 18:53

Rebase + don't be dumb and actually give the commands to complete the task without having to think about it

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Jan 11 2019, 19:01

This revision is now accepted and ready to land.Jan 11 2019, 19:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4490: Diff 6619.Jan 11 2019, 19:09

Closed by commit rABC6b1219302b6f: Add commands to copy the manifest files as part of the gitian building process… (authored by jasonbcox). · Explain WhyJan 11 2019, 21:25

This revision was automatically updated to reflect the committed changes.