Page MenuHomePhabricator

Fix unknown arguments from check-doc.py
ClosedPublic

Authored by Fabien on Jan 14 2019, 11:32.

Details

Summary

The -zmq* arguments are not catched by the regex because they are
using a totally different pattern to get the arguments. A false positive
set has been added to check-doc.py to handle these special cases.

The -nodebug entry is an alias for -debug=0. Starting with "-no" it
is interpreted as a boolean with "false" value for the key "debug".
Boolean arguments are actully strings "0" for "false" and "1" for
"true", hence -nodebug is equivalent to -debug=0

The -fuzzmessagestest is no longer used and can be removed from the
documentation.

Depends on D2303

Test Plan
make
./contrib/devtools/check-doc.py

Check there is no unknown argument in the output (empty set)
Check that the count of args used = (count of args documented + count of
args that don't need documentation)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
argument_unknown
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4503
Build 7069: Bitcoin ABC Buildbot (legacy)
Build 7068: arc lint + arc unit

Event Timeline

deadalnix added inline comments.
src/init.cpp
687

This kind of change should be in their own diffs as they could be delayed due to review of unrelated code.

This revision is now accepted and ready to land.Jan 14 2019, 16:47
This revision was automatically updated to reflect the committed changes.