Page MenuHomePhabricator
Differential D2317

[RCU] Add facility to register cleanup actions to be run when other thread catch up
ClosedPublic
Actions

Authored by deadalnix on Jan 15 2019, 18:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING7f396108c438: [RCU] Add facility to register cleanup actions to be run when other thread…
rABC7f396108c438: [RCU] Add facility to register cleanup actions to be run when other thread…
Summary

In order to avoid the need for synchronization every time a cleanup action is required, it is preferable to register the cleanups and run the cleanup all at once when synchronization is requested.

Test Plan

Added test cases to check cleanups are running as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rcucleanup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4532
Build 7127: Bitcoin ABC Buildbot (legacy)
Build 7126: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 15 2019, 18:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2019, 18:04
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 15 2019, 18:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 6675.Jan 15 2019, 18:14
  • Make sure hasSyncedTo return a reasonable upper bound.
  • Simplify the synchronized loop.
teamcity added a comment.Jan 15 2019, 18:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 15 2019, 18:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4532: Diff 6674.Jan 15 2019, 18:16
teamcity added a comment.Jan 15 2019, 18:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4533: Diff 6675.Jan 15 2019, 18:24
deadalnix added a child revision: D2336: Implement delete function for the RadixTree.Jan 18 2019, 00:57
deadalnix added a child revision: D2340: [RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other threads did synchronize..Jan 18 2019, 20:21
Fabien requested changes to this revision.Jan 21 2019, 17:42
Fabien added a subscriber: Fabien.

One nit in comment, looks good otherwise

src/rcu.cpp
208 ↗(On Diff #6675)

fromthe => from the

This revision now requires changes to proceed.Jan 21 2019, 17:42
deadalnix updated this revision to Diff 6793.Jan 21 2019, 19:03

Fix typo

teamcity added a comment.Jan 21 2019, 19:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 21 2019, 19:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4620: Diff 6793.Jan 21 2019, 19:11
Fabien accepted this revision.Jan 21 2019, 19:15
This revision is now accepted and ready to land.Jan 21 2019, 19:15
Closed by commit rABC7f396108c438: [RCU] Add facility to register cleanup actions to be run when other thread… (authored by deadalnix). · Explain WhyJan 21 2019, 20:46
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGING7f396108c438: [RCU] Add facility to register cleanup actions to be run when other thread….Sep 18 2019, 21:59

Revision Contents
Changeset List

PathSize
src/
18 lines
60 lines
test/
66 lines

Diff 6674

View Options

src/rcu.h

Loading...
View Options

src/rcu.cpp

Loading...
View Options

src/test/rcu_tests.cpp

Loading...