Page MenuHomePhabricator
Differential D2324

Remove -magneticanomalyactivationtime from functional tests
ClosedPublic
Actions

Authored by Fabien on Jan 16 2019, 09:46.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING96cc3af114b7: Remove -magneticanomalyactivationtime from functional tests
rABC96cc3af114b7: Remove -magneticanomalyactivationtime from functional tests
Summary

The tests that checked for magnetic activation are removed, the others
are updated.

Test Plan
./test/functional/test_runner.py abc-magnetic-anomaly-mining

abc-replay-protection abc-transaction-ordering

Diff Detail

Repository
rABC Bitcoin ABC
Branch
magnetic_update_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4559
Build 7181: Bitcoin ABC Buildbot (legacy)
Build 7180: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 16 2019, 09:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2019, 09:46
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 16 2019, 09:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 16 2019, 09:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4541: Diff 6689.Jan 16 2019, 09:56
Fabien mentioned this in D2318: Remove magnetic anomaly transitional code, activate on block height.Jan 16 2019, 10:02
Fabien updated this revision to Diff 6692.Jan 16 2019, 10:31

Remove deleted tests from timings.json

teamcity added a comment.Jan 16 2019, 10:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 16 2019, 10:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4544: Diff 6692.Jan 16 2019, 10:41
deadalnix requested changes to this revision.Jan 17 2019, 01:16
deadalnix added inline comments.
test/functional/abc-transaction-ordering.py
201 ↗(On Diff #6692)

These 6 blocks are not useful for the purpose of the test now that we don't need to activate.

This revision now requires changes to proceed.Jan 17 2019, 01:16
Fabien updated this revision to Diff 6708.Jan 17 2019, 08:01

Remove remaining unused blocks

test/functional/abc-transaction-ordering.py
193

This needed to be increased for coinbase maturation

teamcity added a comment.Jan 17 2019, 08:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 17 2019, 08:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4559: Diff 6708.Jan 17 2019, 08:12
Fabien added a child revision: D2318: Remove magnetic anomaly transitional code, activate on block height.Jan 17 2019, 18:10
deadalnix accepted this revision.Jan 17 2019, 23:48
This revision is now accepted and ready to land.Jan 17 2019, 23:48
deadalnix added inline comments.Jan 17 2019, 23:49
test/functional/abc-transaction-ordering.py
20

You can keep 2000000000, the whole point is for it to be far in the future, not the actual value.

Fabien updated this revision to Diff 6822.Jan 22 2019, 15:08

Set REPLAY_PROTECTION_START_TIME to 2000000000 to be consistent with other far future values

teamcity added a comment.Jan 22 2019, 15:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 22 2019, 15:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4646: Diff 6822.Jan 22 2019, 15:27
Closed by commit rABC96cc3af114b7: Remove -magneticanomalyactivationtime from functional tests (authored by Fabien). · Explain WhyJan 22 2019, 15:44
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING96cc3af114b7: Remove -magneticanomalyactivationtime from functional tests.Sep 18 2019, 21:59

Revision Contents
Changeset List

Diff 6708

View Options

test/functional/abc-checkdatasig-activation.py

Loading...
View Options

test/functional/abc-magnetic-anomaly-activation.py

Loading...
View Options

test/functional/abc-magnetic-anomaly-mining.py

Loading...
View Options

test/functional/abc-replay-protection.py

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...
View Options

test/functional/timing.json

Loading...