Page MenuHomePhabricator

Remove -magneticanomalyactivationtime from functional tests
ClosedPublic

Authored by Fabien on Jan 16 2019, 09:46.

Details

Summary

The tests that checked for magnetic activation are removed, the others
are updated.

Test Plan
./test/functional/test_runner.py abc-magnetic-anomaly-mining

abc-replay-protection abc-transaction-ordering

Diff Detail

Repository
rABC Bitcoin ABC
Branch
magnetic_update_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4541
Build 7145: Bitcoin ABC Buildbot (legacy)
Build 7144: arc lint + arc unit

Event Timeline

Remove deleted tests from timings.json

deadalnix requested changes to this revision.Jan 17 2019, 01:16
deadalnix added inline comments.
test/functional/abc-transaction-ordering.py
201 ↗(On Diff #6692)

These 6 blocks are not useful for the purpose of the test now that we don't need to activate.

This revision now requires changes to proceed.Jan 17 2019, 01:16

Remove remaining unused blocks

test/functional/abc-transaction-ordering.py
193 ↗(On Diff #6708)

This needed to be increased for coinbase maturation

This revision is now accepted and ready to land.Jan 17 2019, 23:48
test/functional/abc-transaction-ordering.py
20 ↗(On Diff #6708)

You can keep 2000000000, the whole point is for it to be far in the future, not the actual value.

Set REPLAY_PROTECTION_START_TIME to 2000000000 to be consistent with other far future values

This revision was automatically updated to reflect the committed changes.