Page MenuHomePhabricator
Differential D2326

[tests] Add p2p connection to TestNode
ClosedPublic
Actions

Authored by Fabien on Jan 16 2019, 15:29.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGcc751088b4ca: [tests] Add p2p connection to TestNode
rABCcc751088b4ca: [tests] Add p2p connection to TestNode
Summary

Partial backport of core PR11182
(commits 5e5725c and b86c1cd)

p2p connections can now be added to TestNode instances.

This commit also updates the example test to use the new
p2p interface in TestNode to demonstrate usage.

A future commit will update the existing tests to use p2p through the
TestNode.
Test Plan
./test/functional/test_runner.py example_test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11182_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4546
Build 7155: Bitcoin ABC Buildbot (legacy)
Build 7154: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 16 2019, 15:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2019, 15:29
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
Fabien added a child revision: D2327: [Part 1] [tests] Add P2P interface to TestNode.Jan 16 2019, 15:31
teamcity added a subscriber: teamcity.Jan 16 2019, 15:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2328: [Part 2] [tests] Add P2P interface to TestNode.Jan 16 2019, 15:33
Fabien added a child revision: D2329: [Part 3] [tests] Add P2P interface to TestNode.
Fabien added a child revision: D2330: [Part 4] [tests] Add P2P interface to TestNode.Jan 16 2019, 15:35
teamcity added a comment.Jan 16 2019, 15:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4546: Diff 6694.Jan 16 2019, 15:40
jasonbcox accepted this revision.Jan 17 2019, 00:20
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/test_framework/test_node.py
17

Looks like we may be missing some other backports, but since they aren't a direct dependency for these changes, I think we can move along.

This revision is now accepted and ready to land.Jan 17 2019, 00:20
Closed by commit rABCcc751088b4ca: [tests] Add p2p connection to TestNode (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 18 2019, 13:09
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
25 lines
test_framework/
49 lines

Diff 6694

View Options

test/functional/example_test.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...