[QA] Allow addrman loopback tests (add debug option -addrmantest)
ClosedPublic
Actions

Authored by Fabien on Jan 23 2019, 10:40.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGa6442e794e99: [QA] Allow addrman loopback tests (add debug option -addrmantest)
rABCa6442e794e99: [QA] Allow addrman loopback tests (add debug option -addrmantest)

Summary

This add a new debug option which will be later used to test network
limited nodes.

Partial backport of core PR10387 (commit fa999af)

Test Plan

make check

../configure --enable-debug && make
./src/bitcoind --help -help-debug

Check the -addrmantest argument documentation is correct

./src/bitcoind -regtest -datadir=<some_non_default_data_dir> &
./src/bitcoind -regtest -debug=all -addnode=127.0.0.1 -addrmantest=1 &
grep AdvertiseLocal ~/.bitcoin/regtest/debug.log

Check the grep outputs something containing:

AdvertiseLocal: advertising address 127.0.0.1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 23 2019, 10:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 10:40

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Fabien added a child revision: D2389: [QA] fix mininode CAddress ser/deser.Jan 23 2019, 10:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4657: Diff 6861.Jan 23 2019, 10:58

jasonbcox accepted this revision.Jan 23 2019, 17:11

This revision is now accepted and ready to land.Jan 23 2019, 17:11

Closed by commit rABCa6442e794e99: [QA] Allow addrman loopback tests (add debug option -addrmantest) (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyJan 24 2019, 15:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGINGa6442e794e99: [QA] Allow addrman loopback tests (add debug option -addrmantest).Sep 18 2019, 22:04

Revision Contents
Changeset List

Path

Size

src/

init.cpp

2 lines

net.cpp

8 lines

Diff 6908

View Options

src/init.cpp