Page MenuHomePhabricator

Connect to peers with NODE_NETWORK_LIMITED flag
ClosedPublic

Authored by Fabien on Jan 23 2019, 11:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC7a1e39e8364c: Connect to peers with NODE_NETWORK_LIMITED flag
Summary

This allow connecting to peers that have the flag set.
Complete p2p_node_network_limited.py test for the new
behavior.

Partial backport of core PR10387
commits 31c45a9, 6fe57bd, 3f56df5 and eb91835

Test Plan
./test/functional/test_runner.py p2p_node_network_limited.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 23 2019, 11:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 11:18
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Jan 24 2019, 15:00

The way you went at this makes it very difficult to review. This diff introduce plenty of temporary state; most of it actually bad and to immediately refactored in subsequent diffs. This i not just bad because it introduce bad code, but also because this temporary state is hard to compare with any source as it doesn't correspond to a specific commit or PR. There are no good way to check that the code correspond to the PR it is backporting.

This revision now requires changes to proceed.Jan 24 2019, 15:00
deadalnix accepted this revision.Jan 24 2019, 16:07
deadalnix added inline comments.
src/protocol.h
19 ↗(On Diff #6911)

This include do not seems necessary.

This revision is now accepted and ready to land.Jan 24 2019, 16:07
Fabien updated this revision to Diff 6915.Jan 24 2019, 16:21

Move <atomic> from .h to .cpp

This revision was automatically updated to reflect the committed changes.