Connect to peers with NODE_NETWORK_LIMITED flag
ClosedPublic
Actions

Authored by Fabien on Jan 23 2019, 11:18.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7a1e39e8364c: Connect to peers with NODE_NETWORK_LIMITED flag
rABC7a1e39e8364c: Connect to peers with NODE_NETWORK_LIMITED flag

Summary

This allow connecting to peers that have the flag set.
Complete p2p_node_network_limited.py test for the new
behavior.

Partial backport of core PR10387
commits 31c45a9, 6fe57bd, 3f56df5 and eb91835

Test Plan

./test/functional/test_runner.py p2p_node_network_limited.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 23 2019, 11:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 11:18

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2391: Add setter for g_initial_block_download_completed.Jan 23 2019, 11:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4659: Diff 6863.Jan 23 2019, 11:33

The way you went at this makes it very difficult to review. This diff introduce plenty of temporary state; most of it actually bad and to immediately refactored in subsequent diffs. This i not just bad because it introduce bad code, but also because this temporary state is hard to compare with any source as it doesn't correspond to a specific commit or PR. There are no good way to check that the code correspond to the PR it is backporting.

This revision now requires changes to proceed.Jan 24 2019, 15:00

Squash D2391

Fabien edited the summary of this revision. (Show Details)Jan 24 2019, 15:26

Fabien removed a parent revision: D2389: [QA] fix mininode CAddress ser/deser.

Fabien mentioned this in D2391: Add setter for g_initial_block_download_completed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4694: Diff 6911.Jan 24 2019, 15:49

deadalnix accepted this revision.Jan 24 2019, 16:07

deadalnix added inline comments.