Page MenuHomePhabricator
Differential D2391

Add setter for g_initial_block_download_completed
AbandonedPublic
Actions

Authored by Fabien on Jan 23 2019, 11:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Also move the GetDesirableServiceFlag to the cpp to make the flag
variable static.

Partial backport of core PR10387 (commit eb91835)

Depends on D2390

Test Plan
./test/functional/test_runner.py p2p_node_network_limited

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10387_part4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4660
Build 7383: Bitcoin ABC Buildbot (legacy)
Build 7382: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2019, 11:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 11:30
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 23 2019, 11:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 23 2019, 11:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4660: Diff 6864!Jan 23 2019, 11:45
teamcity added a comment.Jan 23 2019, 11:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 23 2019, 12:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4660: Diff 6864.Jan 23 2019, 12:01
deadalnix accepted this revision.Jan 23 2019, 14:45
This revision is now accepted and ready to land.Jan 23 2019, 14:45
Fabien mentioned this in D2390: Connect to peers with NODE_NETWORK_LIMITED flag.Jan 24 2019, 15:25
Fabien planned changes to this revision.Jan 24 2019, 15:26

Waiting for D2390 approval, then will get dropped

Fabien abandoned this revision.Jan 24 2019, 17:14

Squashed

Revision Contents
Changeset List

PathSize
src/
2 lines
15 lines
14 lines

Diff 6864

View Options

src/net_processing.cpp

Loading...
View Options

src/protocol.h

Loading...
View Options

src/protocol.cpp

Loading...