Page MenuHomePhabricator

[Qt] replace fee slider with a Dropdown, extend conf. targets
ClosedPublic

Authored by jasonbcox on Jan 24 2019, 03:24.

Details

Summary

[Qt] replace fee slider with a Dropdown, extend conf. targets
[Qt] migrate old fee slider value to new dropbown Always round up (conservative)

Backport of Core PR10769
https://github.com/bitcoin/bitcoin/pull/10769/files
Completes T509

Test Plan

make check
bitcoin-qt shows dropdown instead of slider as expected

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10769-squashed
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4679
Build 7421: Bitcoin ABC Buildbot (legacy)
Build 7420: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 24 2019, 03:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2019, 03:24
Herald added a subscriber: schancel. · View Herald Transcript
Fabien requested changes to this revision.Jan 24 2019, 07:43

Good otherwise

src/qt/sendcoinsdialog.cpp
267

nit: 0.15 => 0.18.7 (or 0.18.8 ?)

This revision now requires changes to proceed.Jan 24 2019, 07:43
jasonbcox updated this revision to Diff 6925.Jan 24 2019, 18:36

Fix version comment

Fabien accepted this revision.Jan 24 2019, 19:34
This revision is now accepted and ready to land.Jan 24 2019, 19:34
This revision was automatically updated to reflect the committed changes.