Page MenuHomePhabricator
Differential D2406

[Qt] replace fee slider with a Dropdown, extend conf. targets
ClosedPublic
Actions

Authored by jasonbcox on Jan 24 2019, 03:24.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING0f4cf482a122: [Qt] replace fee slider with a Dropdown, extend conf. targets
rABC0f4cf482a122: [Qt] replace fee slider with a Dropdown, extend conf. targets
Summary

[Qt] replace fee slider with a Dropdown, extend conf. targets
[Qt] migrate old fee slider value to new dropbown Always round up (conservative)

Backport of Core PR10769
https://github.com/bitcoin/bitcoin/pull/10769/files
Completes T509

Test Plan

make check
bitcoin-qt shows dropdown instead of slider as expected

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10769-squashed
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4700
Build 7463: Bitcoin ABC Buildbot (legacy)
Build 7462: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 24 2019, 03:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2019, 03:24
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 24 2019, 03:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 24 2019, 03:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4679: Diff 6892.Jan 24 2019, 03:39
Fabien requested changes to this revision.Jan 24 2019, 07:43

Good otherwise

src/qt/sendcoinsdialog.cpp
267 ↗(On Diff #6892)

nit: 0.15 => 0.18.7 (or 0.18.8 ?)

This revision now requires changes to proceed.Jan 24 2019, 07:43
jasonbcox updated this revision to Diff 6925.Jan 24 2019, 18:36

Fix version comment

teamcity added a comment.Jan 24 2019, 18:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 24 2019, 18:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4700: Diff 6925.Jan 24 2019, 18:50
Fabien accepted this revision.Jan 24 2019, 19:34
This revision is now accepted and ready to land.Jan 24 2019, 19:34
Closed by commit rABC0f4cf482a122: [Qt] replace fee slider with a Dropdown, extend conf. targets (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by jasonbcox). · Explain WhyJan 24 2019, 19:51
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING0f4cf482a122: [Qt] replace fee slider with a Dropdown, extend conf. targets.Sep 18 2019, 22:05

Revision Contents
Changeset List

PathSize
src/
qt/
forms/
64 lines
74 lines

Diff 6925

View Options

src/qt/forms/sendcoinsdialog.ui

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...