They were broken by the introduction of mandatory limits on the generated block size.
Details
Details
- Reviewers
freetrader sickpig awemany kyuupichan - Group Reviewers
Restricted Project - Commits
- rSTAGING3b98acd49212: Fix a few integration tests
rABC3b98acd49212: Fix a few integration tests
Run the extended test suite.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fixtests
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 377 Build 377: arc lint + arc unit
Event Timeline
| src/init.cpp | ||
|---|---|---|
| 1404 ↗ | (On Diff #599) | The override of this parameter should not take effect for the enclosing condition when nProposedMaxGeneratedBlockSize > config.GetMaxBlockSize() . I would suggest splitting the condition up into a check <= legacy (with this override) and keep the rejection if > config.GetMaxBlockSize |
| src/init.cpp | ||
|---|---|---|
| 1404 ↗ | (On Diff #599) | You are correct. |
Comment Actions
Have allowsmallgeneratedblocksize only bypass the error when the size is too small. Add a test for the behavior.
Comment Actions
Additional test case also looks good. Accepting.
| src/init.cpp | ||
|---|---|---|
| 1404 ↗ | (On Diff #599) | Modified check looks good to me. |