Fix several potential issues found by sanitizers
ClosedPublic
Actions

Authored by Fabien on Jan 28 2019, 13:59.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGa54598f1e5b4: Fix several potential issues found by sanitizers
rABCa54598f1e5b4: Fix several potential issues found by sanitizers

Summary

Backport of core PR9743

Test Plan

With ubsan:

make check

With tsan:

./src/test/test_bitcoin --run_test=DoS_tests

(this test uses the SetMockTime function)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 28 2019, 13:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2019, 13:59

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4720: Diff 6959.Jan 28 2019, 14:15

Fabien added a child revision: D2423: [logging] log system time and mock time.Jan 28 2019, 14:26

jasonbcox accepted this revision.Jan 28 2019, 18:25

This revision is now accepted and ready to land.Jan 28 2019, 18:25

Closed by commit rABCa54598f1e5b4: Fix several potential issues found by sanitizers (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyJan 28 2019, 19:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGINGa54598f1e5b4: Fix several potential issues found by sanitizers.Sep 18 2019, 22:07

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

6 lines

utiltime.cpp

16 lines

Diff 6967

View Options

src/bitcoin-tx.cpp