Page MenuHomePhabricator
Differential D2425

Format timestamps using ISO 8601 formatting
ClosedPublic
Actions

Authored by Fabien on Jan 28 2019, 15:23.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING70c01b3d9d1d: Format timestamps using ISO 8601 formatting
rABC70c01b3d9d1d: Format timestamps using ISO 8601 formatting
Summary

(e.g. "2018-02-28T12:34:56Z")

  • Z is the zone designator for the zero UTC offset.
  • T is the delimiter used to separate date and time.

This makes it clear for the end-user that the date/time logged is
specified in UTC and not in the local time zone.

Backport of core PR12567

Depends on D2423

Test Plan
make check

./src/bitcoind

Check in the log the the time format is ISO 8601 compliant

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 28 2019, 15:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2019, 15:23
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 28 2019, 15:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 28 2019, 15:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4723: Diff 6962.Jan 28 2019, 15:39
jasonbcox accepted this revision.Jan 28 2019, 18:32
This revision is now accepted and ready to land.Jan 28 2019, 18:32
Closed by commit rABC70c01b3d9d1d: Format timestamps using ISO 8601 formatting (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJan 28 2019, 20:03
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D3423: Fix the timestamp format when -logtimemicros is set.Jun 26 2019, 15:15
Fabien mentioned this in rABCf57e432a8c1a: Fix the timestamp format when -logtimemicros is set.Jun 27 2019, 07:50
Fabien added a commit: rSTAGING70c01b3d9d1d: Format timestamps using ISO 8601 formatting.Sep 18 2019, 22:07
Fabien mentioned this in rSTAGINGf57e432a8c1a: Fix the timestamp format when -logtimemicros is set.Sep 19 2019, 00:36

Revision Contents
Changeset List

PathSize
doc/
1 line
src/
3 lines
8 lines
3 lines
qt/
4 lines
test/
16 lines
8 lines
12 lines
21 lines
wallet/
12 lines
test/
functional/
2 lines
test_framework/
2 lines

Diff 6969

View Options

doc/release-notes.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/logging.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/qt/paymentserver.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/utiltime.h

Loading...
View Options

src/utiltime.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/combine_logs.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...