Page MenuHomePhabricator

add SCRIPT_ENABLE_SCHNORR flag
ClosedPublic

Authored by markblundeberg on Jan 29 2019, 02:56.

Details

Summary

This merely adds the flag -- no change in behaviour yet.
Numerous tests are duplicated in script_tests to make sure that nothing
weird happens when the flag is merely activated.

Test Plan

run test_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jan 29 2019, 02:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2019, 02:56
Herald added a subscriber: schancel. · View Herald Transcript

oops, forgot to include a commit

I am now getting a warning when compiling script_tests.cpp, I guess because that script builder is too long:

../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:433:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {

Not sure how to fix this. :-/

Fabien added a subscriber: Fabien.Jan 29 2019, 17:37

@markblundeberg Did you activate the undefined sanitizer (ubsan) ? This would explain your warning, this is a tool limitation.

In D2430#55413, @Fabien wrote:

@markblundeberg Did you activate the undefined sanitizer (ubsan) ? This would explain your warning, this is a tool limitation.

I didn't do anything out of the ordinary, though I do have libubsan0:amd64 installed.

Regarding the warning: https://github.com/bitcoin/bitcoin/issues/10030 Looks like Core didn't care about the issue much either.

jasonbcox accepted this revision.Jan 29 2019, 23:13
This revision is now accepted and ready to land.Jan 29 2019, 23:13

Regarding the warning: https://github.com/bitcoin/bitcoin/issues/10030 Looks like Core didn't care about the issue much either.

Mmmm that makes sense. Good to know it's as benign as it sounds like.

This revision was automatically updated to reflect the committed changes.