Page MenuHomePhabricator

[tests] Activate 'great wall' in the past
AbandonedPublic

Authored by dagurval on Jan 29 2019, 10:43.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Summary

Activate 'great wall' protocol upgrade in the past by default. This lets us discover incompatiblities before activation.

Test Plan

CI. Manually tested D2341 with this change.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gw-activate-past
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4735
Build 7533: Bitcoin ABC Buildbot (legacy)
Build 7532: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jan 29 2019, 17:31
Fabien added a subscriber: Fabien.

This is a good idea to detect the update issues early ; this works so well that there are 2 test failures on the CI :)
These 2 tests should be fixed before this can be landed, in order to avoid breaking the CI.

This revision now requires changes to proceed.Jan 29 2019, 17:31
jasonbcox requested changes to this revision.Jan 29 2019, 23:22
jasonbcox added a subscriber: jasonbcox.

Agree with Fabien. This is how we identified issues with the previous hardfork activation, but it was never landed on master.

This revision now requires changes to proceed.Jan 29 2019, 23:22

ftr, this was abandoned because other devs found it more or equally important to test for incompatibilites without 'great wall' upgrades enforced.