Page MenuHomePhabricator
Differential D2431

[tests] Activate 'great wall' in the past
AbandonedPublic
Actions

Authored by dagurval on Jan 29 2019, 10:43.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Summary

Activate 'great wall' protocol upgrade in the past by default. This lets us discover incompatiblities before activation.

Test Plan

CI. Manually tested D2341 with this change.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gw-activate-past
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4735
Build 7533: Bitcoin ABC Buildbot (legacy)
Build 7532: arc lint + arc unit

Event Timeline

dagurval created this revision.Jan 29 2019, 10:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2019, 10:43
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 29 2019, 10:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 29 2019, 10:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4735: Diff 6982!Jan 29 2019, 10:59
Fabien requested changes to this revision.Jan 29 2019, 17:31
Fabien added a subscriber: Fabien.

This is a good idea to detect the update issues early ; this works so well that there are 2 test failures on the CI :)
These 2 tests should be fixed before this can be landed, in order to avoid breaking the CI.

This revision now requires changes to proceed.Jan 29 2019, 17:31
dagurval mentioned this in D2437: qa: Temporarily disable test that reads the default datadir location.Jan 29 2019, 23:13
dagurval updated this revision to Diff 7004.Jan 29 2019, 23:20

Add missing newline

teamcity added a comment.Jan 29 2019, 23:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Jan 29 2019, 23:22
jasonbcox added a subscriber: jasonbcox.

Agree with Fabien. This is how we identified issues with the previous hardfork activation, but it was never landed on master.

This revision now requires changes to proceed.Jan 29 2019, 23:22
dagurval added a comment.Jan 29 2019, 23:24

What changes do you want @jasonbcox?

Harbormaster completed remote builds in B4755: Diff 7004.Jan 29 2019, 23:36
teamcity added a comment.Jan 29 2019, 23:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien mentioned this in D2459: Add a cli option to the test framework to add an argument to all nodes.Feb 4 2019, 13:23
dagurval abandoned this revision.Feb 7 2019, 12:49
dagurval added a comment.Feb 8 2019, 10:06

ftr, this was abandoned because other devs found it more or equally important to test for incompatibilites without 'great wall' upgrades enforced.

Fabien mentioned this in D2518: Add an argument to the test framework to enable great wall activation.Feb 8 2019, 10:50
Fabien mentioned this in rABC428ecb5ff458: Add an argument to the test framework to enable great wall activation.Mar 5 2019, 14:40
Fabien mentioned this in rSTAGING428ecb5ff458: Add an argument to the test framework to enable great wall activation.Sep 18 2019, 22:38

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
4 lines

Diff 6982

View Options

test/functional/test_framework/util.py

Loading...