ArgsManager: support config file sections
ClosedPublic
Actions

Authored by Fabien on Jan 29 2019, 14:28.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

Summary

This adds support for network sections in the configuration file.
There is no special case management yet.

Partial backport of core PR11862
Commits 95eb66d, 30f9407 and 8a9817d

Depends on D2433

Test Plan

make check
./test/functional/test_runner.py feature_config_args

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision is now accepted and ready to land.Jan 29 2019, 19:13

Rebase

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			doc/release-notes.md (13 lines)
M			src/chainparamsbase.cpp (1 line)
M			src/test/util_tests.cpp (70 lines)
M			src/util.h (7 lines)
M			src/util.cpp (43 lines)
M			test/functional/feature_config_args.py (7 lines)
M			test/functional/test_framework/util.py (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6985	c8b90a1		Jan 29 2019, 14:28	★	★
Diff 2	6995	02e4d2a	Rebase	Jan 29 2019, 19:30	★	★
Diff 3	7181	c8ab745	rABCf3a3fd103236bd7a32dd79fc2cb4d86f41bb7572	Feb 5 2019, 07:57	★	★

Status	Author	Revision
Closed	Fabien	D2436 ArgsManager: special handling for -regtest and -testnet
Closed	Fabien	D2435 Limit some options to only apply on mainnet when in default section
Closed	Fabien	D2434 ArgsManager: support config file sections
Closed	Fabien	D2433 ArgsManager: drop m_negated_args
Closed	Fabien	D2432 ArgsManager: keep command line and config file arguments separate