Page MenuHomePhabricator

ArgsManager: special handling for -regtest and -testnet
ClosedPublic

Authored by Fabien on Jan 29 2019, 15:25.

Details

Summary

Detects and avoid setting network paramter in another network section.

Partial backport of core PR11862
Commits 5e3cbe0 and c25321f

Depends on D2435

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 29 2019, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2019, 15:25
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox edited the summary of this revision. (Show Details)Jan 29 2019, 19:32
Fabien edited the summary of this revision. (Show Details)Jan 29 2019, 19:33
Fabien updated this revision to Diff 6997.

Rebase

jasonbcox accepted this revision.Jan 29 2019, 19:35
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/util.cpp
259 ↗(On Diff #6988)

Nit: comment style:

/**
 * text
 */
This revision is now accepted and ready to land.Jan 29 2019, 19:35
This revision was automatically updated to reflect the committed changes.