Page MenuHomePhabricator
Differential D2436

ArgsManager: special handling for -regtest and -testnet
ClosedPublic
Actions

Authored by Fabien on Jan 29 2019, 15:25.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING300531300aee: ArgsManager: special handling for -regtest and -testnet
rABC300531300aee: ArgsManager: special handling for -regtest and -testnet
Summary

Detects and avoid setting network paramter in another network section.

Partial backport of core PR11862
Commits 5e3cbe0 and c25321f

Depends on D2435

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 29 2019, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2019, 15:25
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 29 2019, 15:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 29 2019, 15:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4741: Diff 6988.Jan 29 2019, 15:39
jasonbcox edited the summary of this revision. (Show Details)Jan 29 2019, 19:32
Fabien updated this revision to Diff 6997.Jan 29 2019, 19:33
Fabien edited the summary of this revision. (Show Details)

Rebase

teamcity added a comment.Jan 29 2019, 19:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Jan 29 2019, 19:35
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/util.cpp
259 ↗(On Diff #6988)

Nit: comment style:

/**
 * text
 */
This revision is now accepted and ready to land.Jan 29 2019, 19:35
teamcity added a comment.Jan 29 2019, 19:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4748: Diff 6997.Jan 29 2019, 19:48
Closed by commit rABC300531300aee: ArgsManager: special handling for -regtest and -testnet (authored by Anthony Towns <aj@erisian.com.au>, committed by Fabien). · Explain WhyFeb 5 2019, 07:59
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING300531300aee: ArgsManager: special handling for -regtest and -testnet.Sep 18 2019, 22:16

Revision Contents
Changeset List

PathSize
src/
test/
27 lines
22 lines

Diff 7183

View Options

src/test/util_tests.cpp

Loading...
View Options

src/util.cpp

Loading...