Page MenuHomePhabricator

Make c++14 standard the default for compilation
Changes PlannedPublic

Authored by Fabien on Thu, Jan 31, 16:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title.
Note that this will make it difficult to run bitcoin-abc on OpenBSD with
the current documentation, due to the old gcc version which does not
support c++14.

Test Plan
make check

Run gitian builds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c++14
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4794
Build 7651: Bitcoin ABC Teamcity Staging
Build 7650: arc lint + arc unit

Event Timeline

Fabien created this revision.Thu, Jan 31, 16:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 31, 16:37
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Thu, Jan 31, 22:06

We need to have someone test this on OSX.

Also it'd be better if we do this after the freeze date. Requesting change to clear my queue, but please request review again after Feb, 15.

This revision now requires changes to proceed.Thu, Jan 31, 22:06
Fabien planned changes to this revision.Thu, Jan 31, 23:09

I would also have someone to test on OSX, atm I only checked that it builds on gitian.
I'm keeping it out of queue for now.