Page MenuHomePhabricator
Differential D2464

Use c++14 generic std::rbegin() and std::rend() instead of class methods
ClosedPublic
Actions

Authored by Fabien on Jan 31 2019, 16:42.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGb5f4aa110a60: Use c++14 generic std::rbegin() and std::rend() instead of class methods
rABCb5f4aa110a60: Use c++14 generic std::rbegin() and std::rend() instead of class methods
rABC49fa7d507420: Use c++14 generic std::rbegin() and std::rend() instead of class methods
Summary

This makes the code more consistent

Depends on D2462

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 31 2019, 16:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2019, 16:42
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 31 2019, 16:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 31 2019, 17:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4796: Diff 7069.Jan 31 2019, 17:03
jasonbcox accepted this revision.Feb 5 2019, 22:38
This revision is now accepted and ready to land.Feb 5 2019, 22:38
Fabien updated this revision to Diff 7903.Apr 2 2019, 09:52

Rebase

teamcity added a comment.Apr 2 2019, 09:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5354: Diff 7903.Apr 2 2019, 10:06
teamcity added a comment.Apr 2 2019, 10:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC49fa7d507420: Use c++14 generic std::rbegin() and std::rend() instead of class methods (authored by Fabien). · Explain WhyApr 9 2019, 18:32
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGINGb5f4aa110a60: Use c++14 generic std::rbegin() and std::rend() instead of class methods.Sep 18 2019, 22:56

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 8016

View Options

src/rwcollection.h

Loading...