Revert "Merge #10712: Add change output if necessary to reduce excess fee"
ClosedPublic
Actions

Authored by jasonbcox on Feb 8 2019, 03:42.

Details

Reviewers

deadalnix
Fabien
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGd22f9b079538: Revert "Merge #10712: Add change output if necessary to reduce excess fee"
rABCd22f9b079538: Revert "Merge #10712: Add change output if necessary to reduce excess fee"

Summary

This reverts commit 06c232f380610b2d39411a9b3372b25b3a36c8cc.

rpc_fundrawtransaction is broken on master.

Test Plan

test_runnery.py rpc_fundrawtransaction passes

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4911
Build 7885: Bitcoin ABC Buildbot (legacy)
Build 7884: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 8 2019, 03:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2019, 03:42

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4911: Diff 7234.Feb 8 2019, 03:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Yikes -- seems like no harm in reverting if it was good before.

This revision is now accepted and ready to land.Feb 8 2019, 03:58

Closed by commit rABCd22f9b079538: Revert "Merge #10712: Add change output if necessary to reduce excess fee" (authored by jasonbcox). · Explain WhyFeb 8 2019, 04:35

This revision was automatically updated to reflect the committed changes.

jasonbcox mentioned this in D2522: [QA] Fix typo in fundrawtransaction test.Feb 8 2019, 18:43

jasonbcox mentioned this in rABC4460385844a9: [QA] Fix typo in fundrawtransaction test.Feb 8 2019, 19:27

jasonbcox mentioned this in D2526: Merge #10712: Add change output if necessary to reduce excess fee.Feb 8 2019, 23:47

jasonbcox mentioned this in rABC268be8dd95e0: Merge #10712: Add change output if necessary to reduce excess fee.Feb 10 2019, 05:35

jasonbcox added a commit: rSTAGINGd22f9b079538: Revert "Merge #10712: Add change output if necessary to reduce excess fee".Sep 18 2019, 22:19

jasonbcox mentioned this in rSTAGING4460385844a9: [QA] Fix typo in fundrawtransaction test.

jasonbcox mentioned this in rSTAGING268be8dd95e0: Merge #10712: Add change output if necessary to reduce excess fee.Sep 18 2019, 22:21

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

137 lines

Diff 7234

View Options

Revert "Merge #10712: Add change output if necessary to reduce excess fee"ClosedPublicActions