Page MenuHomePhabricator

[QA] Renaming rawtx into rawTx
ClosedPublic

Authored by jasonbcox on Fri, Feb 8, 18:58.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rABC622196dc3d13: [QA] Renaming rawtx into rawTx
Summary

Follow up from #10069

fundrawtransaction.py is using two variables: rawtx and rawTx, which can be easily confused (see #10069). This PR rename everything in rawtx.

Inverted backport of Core PR10083 (rawtx -> rawTx instead of rawTx -> rawtx)
Depends on D2522

Test Plan

test_runner.py rpc_fundrawtransaction

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Fri, Feb 8, 18:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 8, 18:58
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Fri, Feb 8, 19:01
deadalnix added inline comments.
test/functional/rpc_fundrawtransaction.py
341 ↗(On Diff #7247)

Now this is inconsistent and probably exactly how the error happened in the first place.

This revision now requires changes to proceed.Fri, Feb 8, 19:01
jasonbcox updated this revision to Diff 7251.Fri, Feb 8, 20:06

Rebase + invert the change to be rawtx -> rawTx since this naming is more to style

jasonbcox retitled this revision from [QA] Renaming rawTx into rawtx to [QA] Renaming rawtx into rawTx.Fri, Feb 8, 20:07
jasonbcox edited the summary of this revision. (Show Details)
deadalnix accepted this revision.Fri, Feb 8, 22:38
deadalnix added inline comments.
test/functional/rpc_fundrawtransaction.py
94 ↗(On Diff #7251)

hahahaha, WTF. Seriously...

This revision is now accepted and ready to land.Fri, Feb 8, 22:38
Closed by commit rABC622196dc3d13: [QA] Renaming rawtx into rawTx (authored by NicolasDorier <nicolas.dorier@gmail.com>, committed by jasonbcox). · Explain WhyFri, Feb 8, 23:36
This revision was automatically updated to reflect the committed changes.