Page MenuHomePhabricator
Differential D2523

[QA] Renaming rawtx into rawTx
ClosedPublic
Actions

Authored by jasonbcox on Feb 8 2019, 18:58.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING622196dc3d13: [QA] Renaming rawtx into rawTx
rABC622196dc3d13: [QA] Renaming rawtx into rawTx
Summary

Follow up from #10069

fundrawtransaction.py is using two variables: rawtx and rawTx, which can be easily confused (see #10069). This PR rename everything in rawtx.

Inverted backport of Core PR10083 (rawtx -> rawTx instead of rawTx -> rawtx)
Depends on D2522

Test Plan

test_runner.py rpc_fundrawtransaction

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10083
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4925
Build 7913: Bitcoin ABC Buildbot (legacy)
Build 7912: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 8 2019, 18:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2019, 18:58
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 8 2019, 18:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix requested changes to this revision.Feb 8 2019, 19:01
deadalnix added inline comments.
test/functional/rpc_fundrawtransaction.py
341 ↗(On Diff #7247)

Now this is inconsistent and probably exactly how the error happened in the first place.

This revision now requires changes to proceed.Feb 8 2019, 19:01
teamcity added a comment.Feb 8 2019, 19:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4922: Diff 7247.Feb 8 2019, 19:13
jasonbcox updated this revision to Diff 7251.Feb 8 2019, 20:06

Rebase + invert the change to be rawtx -> rawTx since this naming is more to style

jasonbcox retitled this revision from [QA] Renaming rawTx into rawtx to [QA] Renaming rawtx into rawTx.Feb 8 2019, 20:07
jasonbcox edited the summary of this revision. (Show Details)
teamcity added a comment.Feb 8 2019, 20:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 8 2019, 20:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4925: Diff 7251.Feb 8 2019, 20:21
deadalnix accepted this revision.Feb 8 2019, 22:38
deadalnix added inline comments.
test/functional/rpc_fundrawtransaction.py
94

hahahaha, WTF. Seriously...

This revision is now accepted and ready to land.Feb 8 2019, 22:38
Closed by commit rABC622196dc3d13: [QA] Renaming rawtx into rawTx (authored by NicolasDorier <nicolas.dorier@gmail.com>, committed by jasonbcox). · Explain WhyFeb 8 2019, 23:36
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING622196dc3d13: [QA] Renaming rawtx into rawTx.Sep 18 2019, 22:20

Revision Contents
Changeset List

PathSize
test/
functional/
126 lines

Diff 7251

View Options

test/functional/rpc_fundrawtransaction.py

Loading...