Page MenuHomePhabricator

Remove dependency on BytesIO in feature_nulldummy.py
ClosedPublic

Authored by jasonbcox on Feb 9 2019, 00:01.

Details

Summary

Cleanup

Test Plan

test_runner.py feature_nulldummy

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Feb 9 2019, 00:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2019, 00:02
Herald added a subscriber: schancel. · View Herald Transcript
Fabien requested changes to this revision.Feb 9 2019, 09:05
Fabien added inline comments.
test/functional/feature_nulldummy.py
8 ↗(On Diff #7260)

Please import from messages.py. It works with mininode because it imports all from messages.py for compatibility reason.

92 ↗(On Diff #7260)

You can avoid the unused variable and return directly.

This revision now requires changes to proceed.Feb 9 2019, 09:05
deadalnix accepted this revision.Feb 9 2019, 16:24
jasonbcox updated this revision to Diff 7279.Feb 10 2019, 05:04
jasonbcox marked 2 inline comments as done.

Fix according to feedback

Fabien accepted this revision.Feb 10 2019, 09:39
This revision is now accepted and ready to land.Feb 10 2019, 09:39
This revision was automatically updated to reflect the committed changes.