Page MenuHomePhabricator
Differential D2528

Remove dependency on BytesIO in feature_nulldummy.py
ClosedPublic
Actions

Authored by jasonbcox on Feb 9 2019, 00:01.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING7777c68cf676: Remove dependency on BytesIO in feature_nulldummy.py
rABC7777c68cf676: Remove dependency on BytesIO in feature_nulldummy.py
Summary

Cleanup

Test Plan

test_runner.py feature_nulldummy

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nulldummy-fromhex
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4932
Build 7927: Bitcoin ABC Buildbot (legacy)
Build 7926: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 9 2019, 00:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2019, 00:02
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox mentioned this in D2508: [tests] nulldummy cleanup.Feb 9 2019, 00:02
teamcity added a subscriber: teamcity.Feb 9 2019, 00:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 9 2019, 00:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4932: Diff 7260.Feb 9 2019, 00:17
Fabien requested changes to this revision.Feb 9 2019, 09:05
Fabien added inline comments.
test/functional/feature_nulldummy.py
8

Please import from messages.py. It works with mininode because it imports all from messages.py for compatibility reason.

92

You can avoid the unused variable and return directly.

This revision now requires changes to proceed.Feb 9 2019, 09:05
deadalnix accepted this revision.Feb 9 2019, 16:24
jasonbcox updated this revision to Diff 7279.Feb 10 2019, 05:04
jasonbcox marked 2 inline comments as done.

Fix according to feedback

teamcity added a comment.Feb 10 2019, 05:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 10 2019, 05:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4946: Diff 7279.Feb 10 2019, 05:20
Fabien accepted this revision.Feb 10 2019, 09:39
This revision is now accepted and ready to land.Feb 10 2019, 09:39
Closed by commit rABC7777c68cf676: Remove dependency on BytesIO in feature_nulldummy.py (authored by jasonbcox). · Explain WhyFeb 11 2019, 01:52
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING7777c68cf676: Remove dependency on BytesIO in feature_nulldummy.py.Sep 18 2019, 22:21

Revision Contents
Changeset List

PathSize
test/
functional/
7 lines

Diff 7260

View Options

test/functional/feature_nulldummy.py

Loading...