Page MenuHomePhabricator
Differential D2546

Fix regression in getrawtransaction
ClosedPublic
Actions

Authored by jasonbcox on Feb 13 2019, 23:57.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING2ba3ac5b795d: Fix regression in getrawtransaction
rABC2ba3ac5b795d: Fix regression in getrawtransaction
Summary

Fixes a regression from D2499 where confirmations, time, and blocktime are no longer present in getrawtransaction. Also add sanity checks to rpc_rawtransaction.py to ensure these verbose-only values are included in the future.

This fixes this issue reported on Github: https://github.com/Bitcoin-ABC/bitcoin-abc/issues/303

Test Plan
ninja check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getrawtx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4981
Build 8025: Bitcoin ABC Buildbot (legacy)
Build 8024: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 13 2019, 23:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 13 2019, 23:57
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 13 2019, 23:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Feb 14 2019, 00:03
teamcity added a comment.Feb 14 2019, 00:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4981: Diff 7330.Feb 14 2019, 00:12
deadalnix accepted this revision.Feb 14 2019, 00:59

You may want to report that the backport was fubared, so there is no need to do excavation to figure out what happened.

This revision is now accepted and ready to land.Feb 14 2019, 00:59
jasonbcox mentioned this in D2499: refactor TxToJSON() and ScriptPubKeyToJSON().Feb 14 2019, 01:13
Closed by commit rABC2ba3ac5b795d: Fix regression in getrawtransaction (authored by jasonbcox). · Explain WhyFeb 14 2019, 01:14
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING2ba3ac5b795d: Fix regression in getrawtransaction.Sep 18 2019, 22:23
PiRK mentioned this in D10671: Make raw multisig tests legacy wallet only in rpc_rawtransaction.py.Dec 14 2021, 16:40
PiRK mentioned this in rABCb375c53efa1c: Make raw multisig tests legacy wallet only in rpc_rawtransaction.py.Dec 16 2021, 15:57

Revision Contents
Changeset List

PathSize
src/
rpc/
18 lines
test/
functional/
17 lines

Diff 7330

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/rpc_rawtransaction.py

Loading...