Page MenuHomePhabricator

Fix regression in getrawtransaction
ClosedPublic

Authored by jasonbcox on Feb 13 2019, 23:57.

Details

Summary

Fixes a regression from D2499 where confirmations, time, and blocktime are no longer present in getrawtransaction. Also add sanity checks to rpc_rawtransaction.py to ensure these verbose-only values are included in the future.

This fixes this issue reported on Github: https://github.com/Bitcoin-ABC/bitcoin-abc/issues/303

Test Plan
ninja check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getrawtx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4981
Build 8025: Bitcoin ABC Buildbot (legacy)
Build 8024: arc lint + arc unit

Event Timeline

You may want to report that the backport was fubared, so there is no need to do excavation to figure out what happened.

This revision is now accepted and ready to land.Feb 14 2019, 00:59
This revision was automatically updated to reflect the committed changes.