Page MenuHomePhabricator

Added tests verifying outputs for getblock rpc command
ClosedPublic

Authored by nakihito on Feb 22 2019, 20:44.

Details

Summary

Added tests to verify output from the getblock (verbose) rpc command. Follow up to D2499.

Test Plan

test_runner.py rpc_blockchain

Diff Detail

Repository
rABC Bitcoin ABC
Branch
HexTest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5049
Build 8161: Bitcoin ABC Buildbot (legacy)
Build 8160: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Feb 22 2019, 20:44
deadalnix requested changes to this revision.Feb 23 2019, 00:52
deadalnix added inline comments.
test/functional/rpc_blockchain.py
211

This formatting is really bad. You can do like _test_getblockheader to avoid repeating selfnode[0] all the time.

This revision now requires changes to proceed.Feb 23 2019, 00:53

Reformatted rpc calls to use a node variable like other tests.

This revision is now accepted and ready to land.Feb 25 2019, 22:55
This revision was automatically updated to reflect the committed changes.