Change from overflow to testing integer minimum (eliminate compiler warning)
ClosedPublic
Actions

Authored by freetrader on Jun 23 2017, 10:28.

Details

Reviewers

deadalnix
sickpig
kyuupichan
awemany

Group Reviewers

Restricted Project

Commits

rSTAGING8609fc611590: Change from overflow to testing integer minimum (eliminate compiler warning)
rABC8609fc611590: Change from overflow to testing integer minimum (eliminate compiler warning)

Summary

This test case was badly written, overflowing integer only causes compiler
warning instead of being useful.
Changed to test integer minimum instead.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_compiler_overflow_in_test_case

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 407
Build 407: arc lint + arc unit

Event Timeline

freetrader created this revision.Jun 23 2017, 10:28

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJun 23 2017, 10:28

deadalnix accepted this revision.Jun 23 2017, 10:56

This revision is now accepted and ready to land.Jun 23 2017, 10:56

Closed by commit rABC8609fc611590: Change from overflow to testing integer minimum (eliminate compiler warning) (authored by freetrader, committed by freetrader). · Explain WhyJun 23 2017, 11:55

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

uahfstarttime_tests.cpp

2 lines

Diff 655

View Options

src/test/uahfstarttime_tests.cpp

Change from overflow to testing integer minimum (eliminate compiler warning)ClosedPublicActions