Page MenuHomePhabricator

Fix debug build test failures
ClosedPublic

Authored by Fabien on Mar 1 2019, 07:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC8c68e96fd677: Fix debug build test failures
Summary

Running the tests with debug enabled would fail due to the
AssertLockNotHeld(cs_main) introduced in D2608. Some tests are still
locking cs_main when creating a new block, which now throws an
assertion error.
This diff fixes these tests.

Test Plan
../configure --enable-debug && make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mar 1 2019, 07:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2019, 07:32
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Mar 1 2019, 11:16
This revision is now accepted and ready to land.Mar 1 2019, 11:16
deadalnix added inline comments.Mar 1 2019, 11:17
src/test/finalization_tests.cpp
33 ↗(On Diff #7549)

No braces

53 ↗(On Diff #7549)

No braces

67 ↗(On Diff #7549)

No braces

90 ↗(On Diff #7549)

You don't need braces here.

Fabien updated this revision to Diff 7550.Mar 1 2019, 11:38

Remove useless braces

This revision was automatically updated to reflect the committed changes.