Paths

Table of Contentst

Differential D2640

[CMAKE] Add PIC/PIE flags on non Windows platforms
ClosedPublic
Actions

Authored by Fabien on Mar 4 2019, 16:15.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGcb22eb3fee4a: [CMAKE] Add PIC/PIE flags on non Windows platforms
rABCcb22eb3fee4a: [CMAKE] Add PIC/PIE flags on non Windows platforms

Summary

This diffs adds the -fPIC and -fPIE compiler flags, as well as the
-pie compiler flag.

Test Plan

mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja
../contrib/devtools/security-check.py src/bitcoind

Before the patch, the output would contain PIE, no longer after the
patch.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_pic_pie

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5125
Build 8313: Bitcoin ABC Buildbot (legacy)
Build 8312: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 4 2019, 16:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 4 2019, 16:15

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5125: Diff 7570.Mar 4 2019, 16:28

deadalnix accepted this revision.Mar 4 2019, 17:40

This revision is now accepted and ready to land.Mar 4 2019, 17:40

Closed by commit rABCcb22eb3fee4a: [CMAKE] Add PIC/PIE flags on non Windows platforms (authored by Fabien). · Explain WhyMar 4 2019, 20:11

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in D2660: [CMAKE] Define FORTIFY_SOURCE=2.Mar 7 2019, 17:38

Fabien added a commit: rSTAGINGcb22eb3fee4a: [CMAKE] Add PIC/PIE flags on non Windows platforms.Sep 18 2019, 22:37

Revision Contents
Changeset List

Path

Size

cmake/

modules/

AddCompilerFlags.cmake

10 lines

src/

CMakeLists.txt

9 lines

Diff 7570

View Options

cmake/modules/AddCompilerFlags.cmake