Page MenuHomePhabricator
Differential D2658

[CMAKE] Add stack protection flag
AbandonedPublic
Actions

Authored by Fabien on Mar 6 2019, 15:03.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

This adds the -fstack-protector-all flag as well as the associated
warning -Wstack-protector.

Depends on D2674

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja -v
../contrib/devtools/security-check.py src/bitcoind

Before the patch the output if the security-check script would contain
Canary, and no longer after this patch.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_hardening_stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5164
Build 8391: Bitcoin ABC Buildbot (legacy)
Build 8390: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 6 2019, 15:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2019, 15:03
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 6 2019, 15:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 6 2019, 15:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5164: Diff 7620.Mar 6 2019, 15:19
jasonbcox accepted this revision.Mar 6 2019, 18:50
This revision is now accepted and ready to land.Mar 6 2019, 18:50
Fabien updated this revision to Diff 7659.Mar 8 2019, 15:00

Rebase on top of D2674

Fabien edited the summary of this revision. (Show Details)Mar 8 2019, 15:00
Fabien added a parent revision: D2674: [CMAKE] Add an option to enable/disable hardening.
teamcity added a comment.Mar 8 2019, 15:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 8 2019, 15:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5194: Diff 7659.Mar 8 2019, 15:15
deadalnix added a comment.Mar 12 2019, 15:24

Just port hardening at once. Right now there are no way to check if hardening is ported properly and as this diffs proves, individual steps seems to be broken.

Fabien mentioned this in D2687: [CMAKE] Harden the executables.Mar 13 2019, 13:51
Fabien planned changes to this revision.Mar 13 2019, 14:52

Superseeded by D2687, can be removed when landed.

Fabien mentioned this in rABCa423ecd14cd9: [CMAKE] Harden the executables.Mar 20 2019, 13:46
Fabien abandoned this revision.Mar 20 2019, 17:32

Superseeded by D2687

Fabien mentioned this in rSTAGINGa423ecd14cd9: [CMAKE] Harden the executables.Sep 18 2019, 22:45

Revision Contents
Changeset List

PathSize
src/
3 lines

Diff 7620

View Options

src/CMakeLists.txt

Loading...