Page MenuHomePhabricator
Differential D2677

Wallet: Refactor FundTransaction to accept parameters via CCoinControl
ClosedPublic
Actions

Authored by jasonbcox on Mar 8 2019, 23:13.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGb75d06e7e969: Wallet: Refactor FundTransaction to accept parameters via CCoinControl
rABCb75d06e7e969: Wallet: Refactor FundTransaction to accept parameters via CCoinControl
Summary

Backport of Core PR9672 commit 891c5ee
https://github.com/bitcoin/bitcoin/pull/9672/commits/891c5eeec2dbf295d14e8f888de02637367dd930
The rest of the backport is RBF related and not needed.
Completes T546
Depends on D2675

Test Plan
ninja check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr9672
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5198
Build 8459: Bitcoin ABC Buildbot (legacy)
Build 8458: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 8 2019, 23:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2019, 23:13
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 8 2019, 23:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 8 2019, 23:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B5198: Diff 7666!Mar 8 2019, 23:27
teamcity added a comment.Mar 9 2019, 17:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 9 2019, 17:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5198: Diff 7666.Mar 9 2019, 17:35
Fabien accepted this revision.Mar 9 2019, 18:10
This revision is now accepted and ready to land.Mar 9 2019, 18:10
Closed by commit rABCb75d06e7e969: Wallet: Refactor FundTransaction to accept parameters via CCoinControl (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by jasonbcox). · Explain WhyMar 11 2019, 16:05
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGb75d06e7e969: Wallet: Refactor FundTransaction to accept parameters via CCoinControl.Sep 18 2019, 22:41

Revision Contents
Changeset List

PathSize
src/
wallet/
29 lines
7 lines
12 lines

Diff 7666

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...