Page MenuHomePhabricator

[secp256k1] remove guava dep
Needs ReviewPublic

Authored by floreslorca on Tue, Mar 12, 00:53.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

remove overkill depencency to guava

Test Plan

execute previous tests successfully

the JNI part can be built and tested by simply doing

$ ./autogen.sh
$ ./configure --enable-jni --enable-experimental --enable-module-ecdh
$ make check-java

Once https://reviews.bitcoinabc.org/D2686 is passed we can do this automatically

Diff Detail

Repository
rABC Bitcoin ABC
Branch
guava2
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5281
Build 8624: Bitcoin ABC Teamcity Staging
Build 8623: arc lint + arc unit

Event Timeline

floreslorca created this revision.Tue, Mar 12, 00:53
Owners added a reviewer: Restricted Owners Package.Tue, Mar 12, 00:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 12, 00:53
Herald added a subscriber: schancel. · View Herald Transcript
floreslorca edited the test plan for this revision. (Show Details)Tue, Mar 12, 01:05
floreslorca edited the test plan for this revision. (Show Details)
deadalnix requested changes to this revision.Tue, Mar 12, 20:01

Can we get the java tests fixed before changes are made rather than mix the two together ?

This revision now requires changes to proceed.Tue, Mar 12, 20:01

Also, adding a test of the java binding to CI would be beneficial so that we can catch these things.

floreslorca edited the test plan for this revision. (Show Details)Wed, Mar 13, 20:34
floreslorca requested review of this revision.Wed, Mar 20, 06:09
Fabien added a subscriber: Fabien.Wed, Mar 20, 13:24

There seem to be several things in this diff, one is removing the guava dependencies and the others are refactoring (indent and boolean assignations).
You should consider splitting the diff.

floreslorca updated this revision to Diff 7769.Thu, Mar 21, 04:40

remove indentation

Fabien requested changes to this revision.Thu, Mar 21, 08:57

There is some mix with the previous version in the diff, it does not display the difference from master. Could you please rebase on top of master ?

This revision now requires changes to proceed.Thu, Mar 21, 08:57
floreslorca updated this revision to Diff 7796.Fri, Mar 22, 20:32

rebase master

huh i did rebase but it still not showing the proper diff

Fabien added a comment.Fri, Mar 22, 20:36

Did you rebased a single commit ?

floreslorca updated this revision to Diff 7798.Fri, Mar 22, 21:15

remove guava dep in a single commit

floreslorca updated this revision to Diff 7801.Fri, Mar 22, 22:44

remove guava in build script