Page MenuHomePhabricator

Added build-secp256k1.sh for running secp tests in TeamCity
ClosedPublic

Authored by jasonbcox on Tue, Mar 12, 23:59.

Details

Summary

Allows us to test secp builds which currently do not run on TeamCity
Depends on D2717
Depends on D2685 only to get passing tests

TeamCity images have been updated to include the jdk 8 dependency.

Test Plan
sudo apt-get install openjdk-8-jdk # dependencies to build and run the java tests
./contrib/teamcity/build-secp256k1.sh

This fails as expected without D2685 applied and passes with D2685 applied.
Tested on a TeamCity agent instance and locally.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Tue, Mar 12, 23:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 12, 23:59
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix added inline comments.Wed, Mar 13, 02:09
contrib/teamcity/build-secp256k1.sh
8 ↗(On Diff #7692)

Why?

jasonbcox planned changes to this revision.Thu, Mar 14, 17:52
jasonbcox added inline comments.
contrib/teamcity/build-secp256k1.sh
8 ↗(On Diff #7692)

Dunno. This was just copied from build.sh

jasonbcox updated this revision to Diff 7766.Wed, Mar 20, 22:59

Fix various bugs

jasonbcox edited the summary of this revision. (Show Details)Wed, Mar 20, 23:04
jasonbcox edited the test plan for this revision. (Show Details)
jasonbcox added inline comments.Wed, Mar 20, 23:10
contrib/teamcity/build-secp256k1.sh
8 ↗(On Diff #7692)

@schancel What situation is the codebase not part of a git repo? I don't see the branch being hit otherwise.

jasonbcox retitled this revision from [WIP] Added build-secp256k1.sh for running secp tests in TeamCity to Added build-secp256k1.sh for running secp tests in TeamCity.Thu, Mar 21, 00:21
jasonbcox added inline comments.Thu, Mar 21, 02:06
contrib/teamcity/build-secp256k1.sh
8 ↗(On Diff #7692)
Shammah
@jasonbcox answer to your question is when the git repo is stripped in transfer. (E.g. when rsyncing it to a remote machine to build, or server side checkout (vs agent checkout))
Or if you download a zip of the source

Jason Cox
so for running locally, right? I dont think teamcity would ever have hit this path

Shammah
If agent checkout is turned off it will.
It checks out the code on the master node and only transfers the source to the build environment.
Without ssh keys or the git metadata.
Fabien accepted this revision.Thu, Mar 21, 10:33
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/teamcity/build-secp256k1.sh
1 ↗(On Diff #7766)

#!/usr/bin/env bash ?

This revision is now accepted and ready to land.Thu, Mar 21, 10:33
jasonbcox added inline comments.Thu, Mar 21, 16:10
contrib/teamcity/build-secp256k1.sh
1 ↗(On Diff #7766)

I haven't tested this on the TeamCity agents. a future diff maybe

This revision was automatically updated to reflect the committed changes.