Added build-secp256k1.sh for running secp tests in TeamCity
ClosedPublic
Actions

Authored by jasonbcox on Mar 12 2019, 23:59.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGcbc12967970f: Added build-secp256k1.sh for running secp tests in TeamCity
rABCcbc12967970f: Added build-secp256k1.sh for running secp tests in TeamCity

Summary

Allows us to test secp builds which currently do not run on TeamCity
Depends on D2717
Depends on D2685 only to get passing tests

TeamCity images have been updated to include the jdk 8 dependency.

Test Plan

sudo apt-get install openjdk-8-jdk # dependencies to build and run the java tests
./contrib/teamcity/build-secp256k1.sh

This fails as expected without D2685 applied and passes with D2685 applied.
Tested on a TeamCity agent instance and locally.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Mar 12 2019, 23:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 12 2019, 23:59

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5214: Diff 7692.Mar 13 2019, 00:14

deadalnix added inline comments.Mar 13 2019, 02:09

contrib/teamcity/build-secp256k1.sh
8 ↗	(On Diff #7692)	Why?

jasonbcox planned changes to this revision.Mar 14 2019, 17:52

jasonbcox added inline comments.

contrib/teamcity/build-secp256k1.sh
8 ↗	(On Diff #7692)	Dunno. This was just copied from build.sh

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox edited the summary of this revision. (Show Details)Mar 20 2019, 22:11

jasonbcox added a parent revision: D2717: Allow for running secp256k1 java build/tests out of tree.

Fix various bugs

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Mar 20 2019, 23:04

jasonbcox edited the test plan for this revision. (Show Details)

jasonbcox added a parent revision: D2685: [secp256k1] fix java secp256k1 test.

jasonbcox added inline comments.Mar 20 2019, 23:10

contrib/teamcity/build-secp256k1.sh
8 ↗	(On Diff #7692)	@schancel What situation is the codebase not part of a git repo? I don't see the branch being hit otherwise.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5261: Diff 7766.Mar 20 2019, 23:15

jasonbcox retitled this revision from [WIP] Added build-secp256k1.sh for running secp tests in TeamCity to Added build-secp256k1.sh for running secp tests in TeamCity.Mar 21 2019, 00:21

jasonbcox added inline comments.Mar 21 2019, 02:06

contrib/teamcity/build-secp256k1.sh

8 ↗

(On Diff #7692)

Shammah
@jasonbcox answer to your question is when the git repo is stripped in transfer. (E.g. when rsyncing it to a remote machine to build, or server side checkout (vs agent checkout))
Or if you download a zip of the source

Jason Cox
so for running locally, right? I dont think teamcity would ever have hit this path

Shammah
If agent checkout is turned off it will.
It checks out the code on the master node and only transfers the source to the build environment.
Without ssh keys or the git metadata.

Fabien accepted this revision.Mar 21 2019, 10:33

Fabien added a subscriber: Fabien.

Fabien added inline comments.