[secp256k1] fix java secp256k1 test
ClosedPublic
Actions

Authored by floreslorca on Mar 12 2019, 22:54.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING737ff23ed292: [secp256k1] fix java secp256k1 test
rABC737ff23ed292: [secp256k1] fix java secp256k1 test

Summary

fix java secp256k1 test

Test Plan

to run the java secp256k1 tests (including this one):

$ cd src/secp256k1
$ ./autogen.sh
$ ./configure --enable-jni --enable-experimental --enable-module-ecdh
$ make check-java

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

floreslorca created this revision.Mar 12 2019, 22:54

Owners added a reviewer: Restricted Owners Package.Mar 12 2019, 22:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 12 2019, 22:54

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5213: Diff 7691.Mar 12 2019, 23:10

Please provide a detailed test plan. Running the tests is not sufficient as this specific test is not ran by default.

This revision now requires changes to proceed.Mar 12 2019, 23:33

jasonbcox mentioned this in D2686: Added build-secp256k1.sh for running secp tests in TeamCity.Mar 12 2019, 23:59

In D2685#62747, @deadalnix wrote:

Please provide a detailed test plan. Running the tests is not sufficient as this specific test is not ran by default.

It should be tested automatically when this is done.
https://reviews.bitcoinabc.org/D2686
Here it is what to do when testing manually

$ cd src/secp256k1
$ ./autogen.sh
$ ./configure --enable-jni --enable-experimental --enable-module-ecdh
$ make check-java

floreslorca edited the test plan for this revision. (Show Details)Mar 13 2019, 20:35

Is that test plan sufficient? It would be great if we can get this moving. I already finished the schnorr jni bindings but they depend on this and https://reviews.bitcoinabc.org/D2681. plus another commit that allows compressed/not compressed for ecdsa

floreslorca requested review of this revision.Mar 20 2019, 06:08

Fabien accepted this revision.Mar 20 2019, 10:46

Fabien mentioned this in D2717: Allow for running secp256k1 java build/tests out of tree.Mar 20 2019, 21:33

jasonbcox added a child revision: D2686: Added build-secp256k1.sh for running secp tests in TeamCity.Mar 20 2019, 23:04

Fabien mentioned this in rABC232eb7ae769d: Allow for running secp256k1 java build/tests out of tree.Mar 21 2019, 22:51