Page MenuHomePhabricator

[secp256k1] fix java secp256k1 test
ClosedPublic

Authored by floreslorca on Mar 12 2019, 22:54.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING737ff23ed292: [secp256k1] fix java secp256k1 test
rABC737ff23ed292: [secp256k1] fix java secp256k1 test
Summary

fix java secp256k1 test

Test Plan

to run the java secp256k1 tests (including this one):

$ cd src/secp256k1
$ ./autogen.sh
$ ./configure --enable-jni --enable-experimental --enable-module-ecdh
$ make check-java

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

floreslorca created this revision.Mar 12 2019, 22:54
Owners added a reviewer: Restricted Owners Package.Mar 12 2019, 22:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 12 2019, 22:54
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Mar 12 2019, 23:33

Please provide a detailed test plan. Running the tests is not sufficient as this specific test is not ran by default.

This revision now requires changes to proceed.Mar 12 2019, 23:33
floreslorca added a comment.EditedMar 13 2019, 20:30

Please provide a detailed test plan. Running the tests is not sufficient as this specific test is not ran by default.

It should be tested automatically when this is done.
https://reviews.bitcoinabc.org/D2686
Here it is what to do when testing manually

$ cd src/secp256k1
$ ./autogen.sh
$ ./configure --enable-jni --enable-experimental --enable-module-ecdh
$ make check-java
floreslorca edited the test plan for this revision. (Show Details)Mar 13 2019, 20:35
floreslorca added a comment.EditedMar 15 2019, 18:31

Is that test plan sufficient? It would be great if we can get this moving. I already finished the schnorr jni bindings but they depend on this and https://reviews.bitcoinabc.org/D2681. plus another commit that allows compressed/not compressed for ecdsa

floreslorca requested review of this revision.Mar 20 2019, 06:08
Fabien accepted this revision.Mar 20 2019, 10:46
jasonbcox requested changes to this revision.Mar 22 2019, 00:46
jasonbcox added a subscriber: jasonbcox.

Please wait until I've updated the TeamCity config.

This revision now requires changes to proceed.Mar 22 2019, 00:46
jasonbcox accepted this revision.Mar 22 2019, 19:10

secp256k1 tests are passing on TeamCity now :)

deadalnix accepted this revision.Mar 22 2019, 19:21
This revision is now accepted and ready to land.Mar 22 2019, 19:21
This revision was automatically updated to reflect the committed changes.