Change the linter to accept a file as an argument, and always return 0
to avoid arcanist to throw a script execution error.
Add a php class to interpret the linter output and display linting error
messages through arc lint.
Depends on D2704
Details
Details
- Reviewers
deadalnix jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGINGf00d08b715e9: [LINTER] Integrate lint-locale-dependence.sh into arcanist
rABCf00d08b715e9: [LINTER] Integrate lint-locale-dependence.sh into arcanist
arc lint
Comment any of the known exception in the linter-locale-dependence.sh
file and add a comment in the corresponding source file. Check that `arc
lint` displays errors for the source file.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| arcanist/linter/LocalDependenceLinter.php | ||
|---|---|---|
| 57 ↗ | (On Diff #7743) | Require -> Requires |
| 73 ↗ | (On Diff #7743) | <funtion> -> <function> |
| 80 ↗ | (On Diff #7743) | theses -> these |
| test/lint/lint-locale-dependence.sh | ||
| 227 ↗ | (On Diff #7743) | The php script indicates that the linter throws errors, but why is it that the script always returns success? |
| test/lint/lint-locale-dependence.sh | ||
|---|---|---|
| 227 ↗ | (On Diff #7743) | This is due to the way arcanist handle the error codes. |
| test/lint/lint-locale-dependence.sh | ||
|---|---|---|
| 227 ↗ | (On Diff #7743) | I think just differentiating between "linting errors" and "script errors" would be helpful enough. Thanks for the explanation. |