remove unused fnoncriticalerrors variable from cwalletdb::findwallettx
ClosedPublic
Actions

Authored by nakihito on Mar 26 2019, 23:41.

Details

Reviewers

Fabien
jasonbcox
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa639e292d4b4: remove unused fnoncriticalerrors variable from cwalletdb::findwallettx
rABCa639e292d4b4: remove unused fnoncriticalerrors variable from cwalletdb::findwallettx

Summary

remove unused fnoncriticalerrors variable from cwalletdb::findwallettx

Backport of Core PR11923
https://github.com/bitcoin/bitcoin/pull/11923/files

Completes T570

Test Plan

make check
test_runner.py
bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

BackportPR11923

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5312
Build 8686: Bitcoin ABC Buildbot (legacy)
Build 8685: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 26 2019, 23:41

Owners added a reviewer: Restricted Owners Package.Mar 26 2019, 23:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2019, 23:41

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5312: Diff 7843.Mar 26 2019, 23:56

deadalnix accepted this revision.Mar 27 2019, 02:01

This revision is now accepted and ready to land.Mar 27 2019, 02:01

Closed by commit rABCa639e292d4b4: remove unused fnoncriticalerrors variable from cwalletdb::findwallettx (authored by Pierre Rochard <pierre@rochard.org>, committed by nakihito). · Explain WhyMar 29 2019, 20:25

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGa639e292d4b4: remove unused fnoncriticalerrors variable from cwalletdb::findwallettx.Sep 18 2019, 22:49

Revision Contents
Changeset List

Path

Size

src/

wallet/

walletdb.cpp

5 lines

Diff 7843

View Options

remove unused fnoncriticalerrors variable from cwalletdb::findwallettxClosedPublicActions