Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp
ClosedPublic
Actions

Authored by florian on Mar 27 2019, 23:10.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGb9c102a733b9: Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp
rABCb9c102a733b9: Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp

Summary

This warning was hidden under normal conditions because SECP256K1_ARG_NONNULL is bypassed when SECP256K1_BUILD is set. A NULL noncefp means the default nonce function is used.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bench_schnorr

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5318
Build 8698: Bitcoin ABC Buildbot (legacy)
Build 8697: arc lint + arc unit

Event Timeline

florian created this revision.Mar 27 2019, 23:10

Owners added a reviewer: Restricted Owners Package.Mar 27 2019, 23:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2019, 23:10

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5318: Diff 7849.Mar 27 2019, 23:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

florian added a child revision: D2748: Add schnorr sign benchmark.Mar 27 2019, 23:42

deadalnix accepted this revision.Mar 28 2019, 00:10

This revision is now accepted and ready to land.Mar 28 2019, 00:10

florian added a child revision: D2749: Add schnorr verify benchmark.Mar 28 2019, 00:14

Closed by commit rABCb9c102a733b9: Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp (authored by florian). · Explain WhyMar 28 2019, 00:22

This revision was automatically updated to reflect the committed changes.

florian added a commit: rSTAGINGb9c102a733b9: Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp.Sep 19 2019, 14:53

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

include/

secp256k1_schnorr.h

2 lines

Diff 7849

View Options

src/secp256k1/include/secp256k1_schnorr.h

Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefpClosedPublicActions