Page MenuHomePhabricator

Add schnorr verify benchmark
ClosedPublic

Authored by florian on Mar 28 2019, 00:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC8dfaa2198450: Add schnorr verify benchmark
Summary

As per title.

Depends on D2747.

Test Plan

./bench_verify

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

florian created this revision.Mar 28 2019, 00:14
Owners added a reviewer: Restricted Owners Package.Mar 28 2019, 00:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2019, 00:14
Herald added a subscriber: schancel. · View Herald Transcript
Fabien requested changes to this revision.Mar 28 2019, 10:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/src/bench_verify.c
15 ↗(On Diff #7852)

nit: remove space between # and include

This revision now requires changes to proceed.Mar 28 2019, 10:34
florian updated this revision to Diff 7896.Apr 2 2019, 01:43

Remove extra space.

Fabien accepted this revision as: Fabien.Apr 2 2019, 14:59
jasonbcox accepted this revision.Apr 2 2019, 19:00
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/bench_verify.c
91 ↗(On Diff #7896)

Idea for a future diff: make the 20000 a constant and use it throughout this test file.

This revision is now accepted and ready to land.Apr 2 2019, 19:00
This revision was automatically updated to reflect the committed changes.